parisni commented on PR #8716:
URL: https://github.com/apache/hudi/pull/8716#issuecomment-1561342131
OK understood. Thx
On May 24, 2023 6:23:42 AM UTC, Danny Chan ***@***.***> wrote:
>@danny0405 commented on this pull request.
>
>
>
>> @@ -67,6 +89,22 @@ public HoodieBaseParquetWriter(Path file,
> this.recordCountForNextSizeCheck =
DEFAULT_MINIMUM_RECORD_COUNT_FOR_CHECK;
> }
>
>+ protected void handleParquetBloomFilters(ParquetWriter.Builder
parquetWriterbuilder, Configuration hadoopConf) {
>+
parquetWriterbuilder.withBloomFilterEnabled(ParquetOutputFormat.getBloomFilterEnabled(hadoopConf));
>+ // inspired from
https://github.com/apache/parquet-mr/blob/master/parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetOutputFormat.java#L458-L464
>+ hadoopConf.forEach(conf -> {
>+ String key = conf.getKey();
>+ if (key.startsWith(BLOOM_FILTER_ENABLED)) {
>+ String column = key.substring(BLOOM_FILTER_ENABLED.length() + 1,
key.length());
>+ parquetWriterbuilder.withBloomFilterEnabled(column,
Boolean.valueOf(conf.getValue()));
>
>The writer should be shared by all the engines, not just Spark, so it is
necessary to add a basic UT for it.
>
>--
>Reply to this email directly or view it on GitHub:
>https://github.com/apache/hudi/pull/8716#discussion_r1203510212
>You are receiving this because you authored the thread.
>
>Message ID: ***@***.***>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
