danny0405 commented on code in PR #8794:
URL: https://github.com/apache/hudi/pull/8794#discussion_r1204035183


##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/upgrade/FourToFiveUpgradeHandler.java:
##########
@@ -71,4 +83,26 @@ public Map<ConfigProperty, String> upgrade(HoodieWriteConfig 
config, HoodieEngin
     }
     return new HashMap<>();
   }
+
+  private String generatorPartitionPath(HoodieWriteConfig config, 
HoodieTableMetaClient metaClient) {
+    HoodieTableConfig tableConfig = metaClient.getTableConfig();
+    String partitionPath = DEPRECATED_DEFAULT_PARTITION_PATH;
+    try {
+      if (tableConfig.getPartitionFields().isPresent()) {

Review Comment:
   Hive style partitioning is a table config, you can check that first, the 
file path pattern for hive style partioning is kind of deterministic, can we 
concatenate the path manually to get rid of the key gen and mock record?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to