danny0405 commented on code in PR #8794:
URL: https://github.com/apache/hudi/pull/8794#discussion_r1206254627


##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/upgrade/FourToFiveUpgradeHandler.java:
##########
@@ -71,4 +83,26 @@ public Map<ConfigProperty, String> upgrade(HoodieWriteConfig 
config, HoodieEngin
     }
     return new HashMap<>();
   }
+
+  private String generatorPartitionPath(HoodieWriteConfig config, 
HoodieTableMetaClient metaClient) {
+    HoodieTableConfig tableConfig = metaClient.getTableConfig();
+    String partitionPath = DEPRECATED_DEFAULT_PARTITION_PATH;
+    try {
+      if (tableConfig.getPartitionFields().isPresent()) {

Review Comment:
   > may be I can only check partitionPath: dt=default and 
dt=default/ht=default in this pr
   
   Agree



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to