jp0317 commented on code in PR #8787:
URL: https://github.com/apache/hudi/pull/8787#discussion_r1203487148


##########
hudi-gcp/src/main/java/org/apache/hudi/gcp/bigquery/BigQuerySyncTool.java:
##########
@@ -96,7 +96,7 @@ private void syncCoWTable(HoodieBigQuerySyncClient 
bqSyncClient) {
         
.setUseFileListingFromMetadata(config.getBoolean(BIGQUERY_SYNC_USE_FILE_LISTING_FROM_METADATA))
         
.setAssumeDatePartitioning(config.getBoolean(BIGQUERY_SYNC_ASSUME_DATE_PARTITIONING))
         .build();
-    manifestFileWriter.writeManifestFile();
+    manifestFileWriter.writeManifestFile(false);
 

Review Comment:
   Hi, this can be exposed as a config in BigQuerySyncConfig? For now we're 
just adding the functionality to the writer.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to