danny0405 commented on code in PR #8787:
URL: https://github.com/apache/hudi/pull/8787#discussion_r1204957224
##########
hudi-gcp/src/main/java/org/apache/hudi/gcp/bigquery/BigQuerySyncTool.java:
##########
@@ -96,7 +96,7 @@ private void syncCoWTable(HoodieBigQuerySyncClient
bqSyncClient) {
.setUseFileListingFromMetadata(config.getBoolean(BIGQUERY_SYNC_USE_FILE_LISTING_FROM_METADATA))
.setAssumeDatePartitioning(config.getBoolean(BIGQUERY_SYNC_ASSUME_DATE_PARTITIONING))
.build();
- manifestFileWriter.writeManifestFile();
+ manifestFileWriter.writeManifestFile(false);
Review Comment:
Let's make it more general so that the SQL/DeltaStreamer user can also
control this option, I'm wondering how necessary the change is, it is like a
`must have` fix for GCP files?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
