danny0405 commented on code in PR #8782:
URL: https://github.com/apache/hudi/pull/8782#discussion_r1204937684
##########
hudi-common/src/main/java/org/apache/hudi/common/table/view/HoodieTableFileSystemView.java:
##########
@@ -199,7 +201,7 @@ protected boolean
isPendingCompactionScheduledForFileId(HoodieFileGroupId fgId)
protected void resetPendingCompactionOperations(Stream<Pair<String,
CompactionOperation>> operations) {
// Build fileId to Pending Compaction Instants
this.fgIdToPendingCompaction =
createFileIdToPendingCompactionMap(operations.map(entry ->
- Pair.of(entry.getValue().getFileGroupId(), Pair.of(entry.getKey(),
entry.getValue()))).collect(Collectors.toMap(Pair::getKey, Pair::getValue)));
+ Pair.of(entry.getValue().getFileGroupId(), Pair.of(entry.getKey(),
entry.getValue()))).collect(Collectors.toConcurrentMap(Pair::getKey,
Pair::getValue)));
}
Review Comment:
Sorry, still think the fix does not work as expected, the value assign
operation like `this.fgIdToPendingCompaction =` is kind of atomic itself,
eventhough multiple threads executes the method concurrently, it is still
thread safe.
And the entrance of the modification like `fgIdToPendingCompaction` is
already guarded by a lock from `#sync` api, more importantly, these internal
states of fs view should be kept in compleness like in instant snapshot, we can
not put two different states from different instants into one map.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
