danny0405 commented on code in PR #8863:
URL: https://github.com/apache/hudi/pull/8863#discussion_r1213988452
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/configuration/HadoopConfigurations.java:
##########
@@ -49,8 +48,7 @@ public static org.apache.hadoop.conf.Configuration
getParquetConf(
*/
public static org.apache.hadoop.conf.Configuration
getHadoopConf(Configuration conf) {
org.apache.hadoop.conf.Configuration hadoopConf =
FlinkClientUtil.getHadoopConf();
- Map<String, String> options =
FlinkOptions.getPropertiesWithPrefix(conf.toMap(), HADOOP_PREFIX);
- options.forEach(hadoopConf::set);
+ conf.toMap().forEach(hadoopConf::set);
Review Comment:
How many s3a options you wanna pass around, what's the problem there if you
prefix all those custom hadoop options with the `hadoop.` prefix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
