linfey90 commented on code in PR #8863:
URL: https://github.com/apache/hudi/pull/8863#discussion_r1218792081
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/configuration/HadoopConfigurations.java:
##########
@@ -49,8 +48,7 @@ public static org.apache.hadoop.conf.Configuration
getParquetConf(
*/
public static org.apache.hadoop.conf.Configuration
getHadoopConf(Configuration conf) {
org.apache.hadoop.conf.Configuration hadoopConf =
FlinkClientUtil.getHadoopConf();
- Map<String, String> options =
FlinkOptions.getPropertiesWithPrefix(conf.toMap(), HADOOP_PREFIX);
- options.forEach(hadoopConf::set);
+ conf.toMap().forEach(hadoopConf::set);
Review Comment:
Sorry for my late reply, do you mean such filtering,
```
// Approach 4: Flink configuration
// add all configuration key with prefix 'flink.hadoop.' in flink
conf to hadoop conf
for (String key : flinkConfiguration.keySet()) {
for (String prefix : FLINK_CONFIG_PREFIXES) {
```
but hudi does not have flink.hadoop prefix cutting, even if it does, it will
be before hadoop prefix filtering.Or do we write it differently, for example,
we use flink.handoop to filter and crop the prefix ourselves.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
