xicm commented on code in PR #8911:
URL: https://github.com/apache/hudi/pull/8911#discussion_r1224098760
##########
hudi-hadoop-mr/src/main/java/org/apache/hudi/hadoop/hive/HoodieCombineHiveInputFormat.java:
##########
@@ -549,21 +567,48 @@ public RecordReader getRecordReader(InputSplit split,
JobConf job, Reporter repo
throw new IOException("cannot find class " + inputFormatClassName);
}
- pushProjectionsAndFilters(job, inputFormatClass, hsplit.getPath(0));
-
+ invokePushProjectAndFilters(job, inputFormatClass, hsplit.getPath(0));
if
(inputFormatClass.getName().equals(getParquetRealtimeInputFormatClassName())) {
HoodieCombineFileInputFormatShim shims = createInputFormatShim();
IOContextMap.get(job).setInputPath(((CombineHiveInputSplit)
split).getPath(0));
return shims.getRecordReader(job, ((CombineHiveInputSplit)
split).getInputSplitShim(),
reporter, CombineHiveRecordReader.class);
} else {
- return
ShimLoader.getHadoopShims().getCombineFileInputFormat().getRecordReader(job,
(CombineFileSplit) split,
- reporter, CombineHiveRecordReader.class);
+ return ShimLoader.getHadoopShims().getCombineFileInputFormat()
+ .getRecordReader(job, (CombineFileSplit) split,
+ reporter, CombineHiveRecordReader.class);
+ }
+ }
+
+ private void invokePushProjectAndFilters(JobConf job, Class<?>
inputFormatClass, Path splitPath)
+ throws IOException {
Review Comment:
@danny0405 Is it better to add a shim class to do
`pushProjectionsAndFilters`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
