xicm commented on code in PR #8911:
URL: https://github.com/apache/hudi/pull/8911#discussion_r1226161654
##########
hudi-hadoop-mr/src/main/java/org/apache/hudi/hadoop/hive/HoodieCombineHiveInputFormat.java:
##########
@@ -401,13 +407,14 @@ private static PartitionDesc
getPartitionFromPath(Map<Path, PartitionDesc> pathT
throws IOException {
Method method;
try {
- Class<?> hiveUtilsClass =
Class.forName("org.apache.hadoop.hive.ql.io.HiveFileFormatUtils");
+ Class<?> hiveUtilsClass =
Class.forName("org.apache.hudi.hadoop.utils.HudiHiveFileFormatUtils");
Review Comment:
Looks good to me, how about adding a shim class to handle differences
between versions? like we do in `org.apache.hudi.hadoop.utils.shims`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
