n3nash commented on a change in pull request #1100:
URL: https://github.com/apache/hudi/pull/1100#discussion_r441245462
##########
File path: hudi-hadoop-mr/pom.xml
##########
@@ -125,6 +125,10 @@
<artifactId>mockito-junit-jupiter</artifactId>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>org.mockito</groupId>
+ <artifactId>mockito-junit-jupiter</artifactId>
Review comment:
It was inherited but made it explicit
##########
File path: hudi-hive-sync/src/main/java/org/apache/hudi/hive/HiveSyncConfig.java
##########
@@ -71,6 +71,9 @@
@Parameter(names = {"--skip-ro-suffix"}, description = "Skip the `_ro`
suffix for Read optimized table, when registering")
public Boolean skipROSuffix = false;
+ @Parameter(names = {"--is-test-suite"}, description = "Hudi test suite")
Review comment:
Removed
##########
File path: hudi-hive-sync/src/main/java/org/apache/hudi/hive/HiveSyncTool.java
##########
@@ -108,6 +108,12 @@ private void syncHoodieTable(String tableName, boolean
useRealtimeInputFormat) {
+ " of type " + hoodieHiveClient.getTableType());
// Check if the necessary table exists
boolean tableExists = hoodieHiveClient.doesTableExist(tableName);
+
+ // check if the database exists else create it
+ if (cfg.isTestSuite) {
+ LOG.info("Test suite specific creation of DB " + cfg.isTestSuite);
Review comment:
Removed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
