n3nash commented on a change in pull request #1100:
URL: https://github.com/apache/hudi/pull/1100#discussion_r441247442
##########
File path: hudi-utilities/pom.xml
##########
@@ -131,6 +131,12 @@
<artifactId>log4j</artifactId>
</dependency>
+ <dependency>
Review comment:
Right now SLF4j and log4j both are used in Hudi (realized this during
the test suite logging). We use it in just the HoodieClientTestHarness class.
Follow up task to remove 1 of them is here ->
https://issues.apache.org/jira/browse/HUDI-1026
##########
File path:
hudi-utilities/src/main/java/org/apache/hudi/utilities/deltastreamer/SourceFormatAdapter.java
##########
@@ -71,11 +71,11 @@ public SourceFormatAdapter(Source source) {
// pass in the schema for the Row-to-Avro conversion
// to avoid nullability mismatch between Avro schema and
Row schema
? AvroConversionUtils.createRdd(
- rdd, r.getSchemaProvider().getSourceSchema(),
- HOODIE_RECORD_STRUCT_NAME,
HOODIE_RECORD_NAMESPACE).toJavaRDD()
+ rdd, r.getSchemaProvider().getSourceSchema(),
Review comment:
Done
##########
File path:
hudi-utilities/src/test/resources/delta-streamer-config/complex-source.avsc
##########
@@ -0,0 +1,466 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+ {
+ "name": "COMPLEX",
Review comment:
Yes, explained reason above.
##########
File path: pom.xml
##########
@@ -86,7 +88,7 @@
<junit.vintage.version>5.6.1</junit.vintage.version>
<mockito.jupiter.version>3.3.3</mockito.jupiter.version>
<log4j.version>1.2.17</log4j.version>
- <slf4j.version>1.7.5</slf4j.version>
+ <slf4j.version>1.7.15</slf4j.version>
Review comment:
yes, filed a ticket
##########
File path: pom.xml
##########
@@ -549,7 +551,52 @@
<version>5.17.2</version>
</dependency>
- <!-- Httpcomponents -->
+ <dependency>
Review comment:
These caused some dependency issues when running tests. I will look into
this shortly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
