prashantwason commented on code in PR #8758:
URL: https://github.com/apache/hudi/pull/8758#discussion_r1229167228
##########
hudi-common/src/main/java/org/apache/hudi/io/storage/HoodieAvroHFileReader.java:
##########
@@ -545,6 +545,33 @@ public void close() {
}
}
+ @Override
+ public ClosableIterator<String> getRecordKeyIterator() {
+ final HFileScanner scanner = reader.getScanner(false, false);
Review Comment:
We are not caching here as the intention of this function is to return an
iterator over all the keys. The iterator would be used once. So there is no
benefit of caching the blocks for later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
