prashantwason commented on code in PR #8758:
URL: https://github.com/apache/hudi/pull/8758#discussion_r1229199409
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java:
##########
@@ -819,9 +917,18 @@ public void buildMetadataPartitions(HoodieEngineContext
engineContext, List<Hood
* @param instantTime Timestamp at which the commit was performed
*/
@Override
- public void update(HoodieCommitMetadata commitMetadata, String instantTime) {
- processAndCommit(instantTime, () ->
HoodieTableMetadataUtil.convertMetadataToRecords(
- engineContext, commitMetadata, instantTime,
getRecordsGenerationParams()));
+ public void update(HoodieCommitMetadata commitMetadata,
HoodieData<WriteStatus> writeStatus, String instantTime) {
+ processAndCommit(instantTime, () -> {
+ Map<MetadataPartitionType, HoodieData<HoodieRecord>>
partitionToRecordMap =
+ HoodieTableMetadataUtil.convertMetadataToRecords(engineContext,
commitMetadata, instantTime, getRecordsGenerationParams());
+
+ // Updates for record index are created by parsing the WriteStatus which
is a hudi-client object. Hence, we cannot yet move this code
+ // to the HoodieTableMetadataUtil class in hudi-common.
+ if (writeStatus != null && !writeStatus.isEmpty()) {
+ partitionToRecordMap.put(MetadataPartitionType.RECORD_INDEX,
getRecordIndexUpdates(writeStatus));
Review Comment:
Because WriteStatus is part of hudi-client
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
