ksmou commented on code in PR #8945:
URL: https://github.com/apache/hudi/pull/8945#discussion_r1229273560


##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/HoodieClusteringJob.java:
##########
@@ -87,7 +87,7 @@ public static class Config implements Serializable {
     public int parallelism = 1;
     @Parameter(names = {"--spark-master", "-ms"}, description = "Spark master")
     public String sparkMaster = null;
-    @Parameter(names = {"--spark-memory", "-sm"}, description = "spark memory 
to use", required = true)
+    @Parameter(names = {"--spark-memory", "-sm"}, description = "spark memory 
to use", required = false)
     public String sparkMemory = null;

Review Comment:
   The purpose of spark-memory is to set spark.executor.memory, which is 
usually configured according to  executor-memory in Spark. We shouldd configure 
both executor-memory and spark-memory if spark-memory is forced to true.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to