danny0405 commented on code in PR #8945:
URL: https://github.com/apache/hudi/pull/8945#discussion_r1230367206


##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/HoodieClusteringJob.java:
##########
@@ -87,7 +87,7 @@ public static class Config implements Serializable {
     public int parallelism = 1;
     @Parameter(names = {"--spark-master", "-ms"}, description = "Spark master")
     public String sparkMaster = null;
-    @Parameter(names = {"--spark-memory", "-sm"}, description = "spark memory 
to use", required = true)
+    @Parameter(names = {"--spark-memory", "-sm"}, description = "spark memory 
to use", required = false)
     public String sparkMemory = null;

Review Comment:
   If coexistence of different values from `--executor-memory` and 
`--spark-memory` is allowed, then keeping the options sounds good to me, it 
gives some space for flexibility.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to