prashantwason commented on code in PR #8758:
URL: https://github.com/apache/hudi/pull/8758#discussion_r1231384456
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieWriteClient.java:
##########
@@ -197,23 +198,24 @@ public boolean commit(String instantTime, O
writeStatuses, Option<Map<String, St
}
public boolean commit(String instantTime, O writeStatuses,
Option<Map<String, String>> extraMetadata,
- String commitActionType, Map<String, List<String>>
partitionToReplacedFileIds) {
+ String commitActionType, Map<String, List<String>>
partitionToReplacedFileIds) {
return commit(instantTime, writeStatuses, extraMetadata, commitActionType,
partitionToReplacedFileIds,
Option.empty());
}
public abstract boolean commit(String instantTime, O writeStatuses,
Option<Map<String, String>> extraMetadata,
- String commitActionType, Map<String,
List<String>> partitionToReplacedFileIds,
- Option<BiConsumer<HoodieTableMetaClient,
HoodieCommitMetadata>> extraPreCommitFunc);
+ String commitActionType, Map<String, List<String>>
partitionToReplacedFileIds,
+ Option<BiConsumer<HoodieTableMetaClient, HoodieCommitMetadata>>
extraPreCommitFunc);
- public boolean commitStats(String instantTime, List<HoodieWriteStat> stats,
Option<Map<String, String>> extraMetadata,
- String commitActionType) {
- return commitStats(instantTime, stats, extraMetadata, commitActionType,
Collections.emptyMap(), Option.empty());
+ public boolean commitStats(String instantTime, HoodieData<WriteStatus>
writeStatuses, List<HoodieWriteStat> stats, Option<Map<String, String>>
extraMetadata,
+ String commitActionType) {
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
