prashantwason commented on code in PR #8758:
URL: https://github.com/apache/hudi/pull/8758#discussion_r1231393071
##########
hudi-common/src/main/java/org/apache/hudi/metadata/BaseTableMetadata.java:
##########
@@ -411,18 +394,9 @@ private void checkForSpuriousDeletes(HoodieMetadataPayload
metadataPayload, Stri
}
}
- private FileSystemBackedTableMetadata createFileSystemBackedTableMetadata() {
- return new FileSystemBackedTableMetadata(getEngineContext(),
dataMetaClient.getSerializableHadoopConf(), dataBasePath.toString(),
- metadataConfig.shouldAssumeDatePartitioning());
- }
-
protected abstract Option<HoodieRecord<HoodieMetadataPayload>>
getRecordByKey(String key, String partitionName);
- public abstract List<Pair<String,
Option<HoodieRecord<HoodieMetadataPayload>>>> getRecordsByKeys(List<String>
key, String partitionName);
-
- protected HoodieEngineContext getEngineContext() {
- return engineContext != null ? engineContext : new
HoodieLocalEngineContext(getHadoopConf());
- }
+ protected abstract Map<String, HoodieRecord<HoodieMetadataPayload>>
getRecordsByKeys(List<String> key, String partitionName);
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
