wombatu-kun commented on code in PR #8994:
URL: https://github.com/apache/hudi/pull/8994#discussion_r1233572345
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/table/HoodieTableSource.java:
##########
@@ -520,10 +520,9 @@ private MergeOnReadInputFormat mergeOnReadInputFormat(
this.schema.getColumnNames().toArray(new String[0]),
this.schema.getColumnDataTypes().toArray(new DataType[0]),
this.requiredPos,
- this.conf.getString(FlinkOptions.PARTITION_DEFAULT_NAME),
this.limit == NO_LIMIT_CONSTANT ? Long.MAX_VALUE : this.limit, //
ParquetInputFormat always uses the limit value
+ this.conf,
getParquetConf(this.conf, this.hadoopConf),
- this.conf.getBoolean(FlinkOptions.UTC_TIMEZONE),
this.internalSchemaManager
Review Comment:
Ok, now i pass to CopyOnWriteInputFormat only necessary params, not the full
flink configuration. Is that what you want? Or you mean not to pass
configuration object at all and pass every configuration parameter
(UTC_TIMEZONE, HIVE_STYLE_PARTITIONING, PARTITION_DEFAULT_NAME,
PARTITION_PATH_FIELD) as a separate argument of constructor and add to
CopyOnWriteInputFormat as a property?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
