wombatu-kun commented on code in PR #8994:
URL: https://github.com/apache/hudi/pull/8994#discussion_r1234978932
##########
hudi-flink-datasource/hudi-flink/src/test/java/org/apache/hudi/table/TestHoodieTableSource.java:
##########
@@ -248,9 +248,9 @@ void testBucketPruningSpecialKeyDataType(boolean
logicalTimestamp) throws Except
HoodieTableSource tableSource1 = createHoodieTableSource(conf1);
tableSource1.applyFilters(Collections.singletonList(createLitEquivalenceExpr(f1,
0, DataTypes.TIMESTAMP(3).notNull(),
LocalDateTime.ofInstant(Instant.ofEpochMilli(1), ZoneId.of("UTC")))));
- assertThat(tableSource1.getDataBucket(), is(logicalTimestamp ? 1 : 0));
+ assertThat(tableSource1.getDataBucket(), is(0));
FileStatus[] fileStatuses = tableSource1.getReadFiles();
- assertThat("Files should be pruned", fileStatuses.length,
CoreMatchers.is(1));
+ assertThat("Files should be pruned", fileStatuses.length,
is(logicalTimestamp ? 0 : 1));
Review Comment:
This test is not affected by my code. It was already broken (in master)
before i made my changes, i don't know why. I've just made it pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
