danny0405 commented on code in PR #9028:
URL: https://github.com/apache/hudi/pull/9028#discussion_r1236993845
##########
hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/util/HivePartitionUtil.java:
##########
@@ -57,7 +57,7 @@ public static String getPartitionClauseForDrop(String
partition, PartitionValueE
// This is a decode operator for encode in
KeyGenUtils#getRecordPartitionPath
partitionValue =
PartitionPathEncodeUtils.unescapePathName(partitionValue);
}
-
partBuilder.add(config.getSplitStrings(META_SYNC_PARTITION_FIELDS).get(i) + "="
+ partitionValue);
+
partBuilder.add(config.getSplitStrings(META_SYNC_PARTITION_FIELDS).get(i).toLowerCase()
+ "=" + partitionValue);
Review Comment:
Does hive throws exception in this case, or does Hive support partition
field as upper-case? Can we just fix the spark queries?
##########
hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/util/HivePartitionUtil.java:
##########
@@ -57,7 +57,7 @@ public static String getPartitionClauseForDrop(String
partition, PartitionValueE
// This is a decode operator for encode in
KeyGenUtils#getRecordPartitionPath
partitionValue =
PartitionPathEncodeUtils.unescapePathName(partitionValue);
}
-
partBuilder.add(config.getSplitStrings(META_SYNC_PARTITION_FIELDS).get(i) + "="
+ partitionValue);
+
partBuilder.add(config.getSplitStrings(META_SYNC_PARTITION_FIELDS).get(i).toLowerCase()
+ "=" + partitionValue);
Review Comment:
Does hive throw exception in this case, or does Hive support partition field
as upper-case? Can we just fix the spark queries?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
