danny0405 commented on code in PR #9028:
URL: https://github.com/apache/hudi/pull/9028#discussion_r1237216006
##########
hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/util/HivePartitionUtil.java:
##########
@@ -57,7 +57,7 @@ public static String getPartitionClauseForDrop(String
partition, PartitionValueE
// This is a decode operator for encode in
KeyGenUtils#getRecordPartitionPath
partitionValue =
PartitionPathEncodeUtils.unescapePathName(partitionValue);
}
-
partBuilder.add(config.getSplitStrings(META_SYNC_PARTITION_FIELDS).get(i) + "="
+ partitionValue);
+
partBuilder.add(config.getSplitStrings(META_SYNC_PARTITION_FIELDS).get(i).toLowerCase()
+ "=" + partitionValue);
Review Comment:
Is there any possibility that we can add a test case for it?
And we can move the `config.getSplitStrings(META_SYNC_PARTITION_FIELDS)` out
of the for-loop.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]