danny0405 commented on code in PR #7336:
URL: https://github.com/apache/hudi/pull/7336#discussion_r1237928231
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/WriteStatus.java:
##########
@@ -87,12 +90,12 @@ public WriteStatus() {
* Mark write as success, optionally using given parameters for the purpose
of calculating some aggregate metrics.
* This method is not meant to cache passed arguments, since WriteStatus
objects are collected in Spark Driver.
*
- * @param record deflated {@code HoodieRecord} containing information that
uniquely identifies it.
+ * @param recordDelegateLazy HoodieKey with location information.
* @param optionalRecordMetadata optional metadata related to data contained
in {@link HoodieRecord} before deflation.
*/
- public void markSuccess(HoodieRecord record, Option<Map<String, String>>
optionalRecordMetadata) {
+ public void markSuccess(Lazy<HoodieRecordDelegate> recordDelegateLazy,
Option<Map<String, String>> optionalRecordMetadata) {
Review Comment:
If we keep the instantTime attribute inside `WriteStatus`, the api can be
simplified as just passing around a `HoodieKey`, because the partitionPath and
fileId are already deterministic for a `WriteStatus`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
