danny0405 commented on code in PR #7336:
URL: https://github.com/apache/hudi/pull/7336#discussion_r1239258442
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/WriteStatus.java:
##########
@@ -52,9 +55,9 @@ public class WriteStatus implements Serializable {
private final HashMap<HoodieKey, Throwable> errors = new HashMap<>();
- private final List<HoodieRecord> writtenRecords = new ArrayList<>();
+ private final List<HoodieRecordDelegate> writtenRecordDelegates = new
ArrayList<>();
- private final List<HoodieRecord> failedRecords = new ArrayList<>();
+ private final List<Pair<HoodieRecordDelegate, Throwable>> failedRecords =
new ArrayList<>();
Review Comment:
Yeah, for success records tracking from HoodieRecords, keep the record as is
should be the most efficient way, here we unify the objects to
`HoodieRecordDelegate` is because there are some code engine specific code path
that does not hold any HoodieRecords, still, I think the API is not that
elegant and we should do some refactoring when can have solution to unify the
HoodieRecords abstractions first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
