Zouxxyy commented on code in PR #9051:
URL: https://github.com/apache/hudi/pull/9051#discussion_r1241899759
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/spark/sql/hudi/command/AlterHoodieTableChangeColumnCommand.scala:
##########
@@ -102,4 +104,8 @@ case class AlterHoodieTableChangeColumnCommand(
", origin table schema :" + tableSchema + ", base path :" +
metaClient.getBasePath)
}
}
+
+ // Add the comment to a column, if comment is empty, return the original
column.
+ private def addComment(column: StructField, comment: Option[String]):
StructField =
Review Comment:
Originally, without this PR, the nullable attribute of the field might be
changed after `alter table change column commnt`(not null -> nullable), but
currently the spark field is always nullable with hudi, so no suitable test
case has been found so far...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
