YannByron commented on code in PR #9051:
URL: https://github.com/apache/hudi/pull/9051#discussion_r1241927484
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/spark/sql/hudi/command/AlterHoodieTableChangeColumnCommand.scala:
##########
@@ -102,4 +104,8 @@ case class AlterHoodieTableChangeColumnCommand(
", origin table schema :" + tableSchema + ", base path :" +
metaClient.getBasePath)
}
}
+
+ // Add the comment to a column, if comment is empty, return the original
column.
+ private def addComment(column: StructField, comment: Option[String]):
StructField =
Review Comment:
Suggest that not only sync the new schema (with new comment) to HMS, but
also keep it in the hudi own meta data. Then you can add a UT by check whether
the underlying avro schema is what you expect after changing the comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
