nsivabalan commented on code in PR #9037:
URL: https://github.com/apache/hudi/pull/9037#discussion_r1242392462
##########
hudi-common/src/main/java/org/apache/hudi/io/storage/HoodieAvroHFileReader.java:
##########
@@ -206,7 +198,12 @@ protected ClosableIterator<IndexedRecord>
getIndexedRecordIterator(Schema reader
}
// TODO eval whether seeking scanner would be faster than pread
- HFileScanner scanner = getHFileScanner(reader, false);
+ HFileScanner scanner = null;
+ try {
+ scanner = getHFileScanner(reader, false, false);
+ } catch (IOException e) {
+ throw new HoodieIOException("Instantiation HfileScanner failed for " +
reader.getHFileInfo().toString());
+ }
Review Comment:
every other method in the interface throws IOException except this method.
So, I let it as is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
