nsivabalan commented on code in PR #9037:
URL: https://github.com/apache/hudi/pull/9037#discussion_r1244093118
##########
hudi-common/src/main/java/org/apache/hudi/common/table/log/block/HoodieHFileDataBlock.java:
##########
@@ -195,11 +193,6 @@ protected <T> ClosableIterator<HoodieRecord<T>>
lookupRecords(List<String> keys,
blockContentLoc.getContentPositionInLogFile(),
blockContentLoc.getBlockSize());
- // HFile read will be efficient if keys are sorted, since on storage
records are sorted by key.
Review Comment:
yeah. I also thought about it. In future, if we had to introduce a new
iterator, we can hope the author does a good job on testing it out and not
catch a simple case of non sorted keys not returning expected results.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
