nsivabalan commented on a change in pull request #1687:
URL: https://github.com/apache/hudi/pull/1687#discussion_r443264032
##########
File path: hudi-client/src/main/java/org/apache/hudi/io/HoodieMergeHandle.java
##########
@@ -132,7 +133,8 @@ private void init(String fileId, String partitionPath,
HoodieBaseFile dataFileTo
// Create the writer for writing the new version file
storageWriter =
- HoodieStorageWriterFactory.getStorageWriter(instantTime,
newFilePath, hoodieTable, config, writerSchema, sparkTaskContextSupplier);
+ HoodieFileWriterFactory.getFileWriter(instantTime, newFilePath,
hoodieTable, config, writerSchema, sparkTaskContextSupplier);
Review comment:
minor: similar to my suggestion in reader, try to see if we need to name
this as getNewFileWriter()
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
