bvaradar commented on pull request #1687: URL: https://github.com/apache/hudi/pull/1687#issuecomment-647588704
@prashantwason : As I was mentioning this earlier, can you split them into 2 PRs with first one containing only. 1. HoodieStorageWriter abstraction for writer and HoodieStorageReader for reading. Subsequent PR contains 2. Implemented support for HFile format 3. Table tests parameterized to run with various base file formats 4. hadoop-mr side Input format also abstracted into HoodieImputFormat and HoodieRealtimeInputFormat classes. - Different base file based InputFormats should derive from these two classes. That way we can land this and unblock other PRs. Let me know if you need any help in this regards. I can help split them with you. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org