yihua commented on code in PR #9078:
URL: https://github.com/apache/hudi/pull/9078#discussion_r1245951413
##########
hudi-utilities/src/test/java/org/apache/hudi/utilities/deltastreamer/TestHoodieDeltaStreamer.java:
##########
@@ -1395,19 +1403,26 @@ public void
testAsyncClusteringServiceWithConflicts(HoodieRecordType recordType)
}
@ParameterizedTest
- @EnumSource(value = HoodieRecordType.class, names = {"AVRO", "SPARK"})
+ @EnumSource(value = HoodieRecordType.class, names = {"AVRO","SPARK"})
Review Comment:
nit: no need to change this line
##########
hudi-utilities/src/test/java/org/apache/hudi/utilities/deltastreamer/TestHoodieDeltaStreamer.java:
##########
@@ -1395,19 +1403,26 @@ public void
testAsyncClusteringServiceWithConflicts(HoodieRecordType recordType)
}
@ParameterizedTest
- @EnumSource(value = HoodieRecordType.class, names = {"AVRO", "SPARK"})
+ @EnumSource(value = HoodieRecordType.class, names = {"AVRO","SPARK"})
public void testAsyncClusteringServiceWithCompaction(HoodieRecordType
recordType) throws Exception {
- String tableBasePath = basePath + "/asyncClusteringCompaction";
+ String tableBasePath = basePath + "/asyncClusteringCompaction" +
RANDOM.nextInt(1000);
// Keep it higher than batch-size to test continuous mode
int totalRecords = 2000;
- // Initial bulk insert
- HoodieDeltaStreamer.Config cfg = TestHelpers.makeConfig(tableBasePath,
WriteOperationType.INSERT);
+ // user upsert as operation type.
Review Comment:
```suggestion
// Use upsert as operation type.
```
##########
hudi-utilities/src/test/java/org/apache/hudi/utilities/deltastreamer/TestHoodieDeltaStreamer.java:
##########
@@ -1395,19 +1403,26 @@ public void
testAsyncClusteringServiceWithConflicts(HoodieRecordType recordType)
}
@ParameterizedTest
- @EnumSource(value = HoodieRecordType.class, names = {"AVRO", "SPARK"})
+ @EnumSource(value = HoodieRecordType.class, names = {"AVRO","SPARK"})
public void testAsyncClusteringServiceWithCompaction(HoodieRecordType
recordType) throws Exception {
- String tableBasePath = basePath + "/asyncClusteringCompaction";
+ String tableBasePath = basePath + "/asyncClusteringCompaction" +
RANDOM.nextInt(1000);
// Keep it higher than batch-size to test continuous mode
int totalRecords = 2000;
- // Initial bulk insert
- HoodieDeltaStreamer.Config cfg = TestHelpers.makeConfig(tableBasePath,
WriteOperationType.INSERT);
+ // user upsert as operation type.
+ HoodieDeltaStreamer.Config cfg = TestHelpers.makeConfig(tableBasePath,
WriteOperationType.UPSERT);
Review Comment:
Will async clustering fail due to the conflict between clustering and
updates in the same file group?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
