nsivabalan commented on code in PR #9078:
URL: https://github.com/apache/hudi/pull/9078#discussion_r1245960669
##########
hudi-utilities/src/test/java/org/apache/hudi/utilities/deltastreamer/TestHoodieDeltaStreamer.java:
##########
@@ -1395,19 +1403,26 @@ public void
testAsyncClusteringServiceWithConflicts(HoodieRecordType recordType)
}
@ParameterizedTest
- @EnumSource(value = HoodieRecordType.class, names = {"AVRO", "SPARK"})
+ @EnumSource(value = HoodieRecordType.class, names = {"AVRO","SPARK"})
public void testAsyncClusteringServiceWithCompaction(HoodieRecordType
recordType) throws Exception {
- String tableBasePath = basePath + "/asyncClusteringCompaction";
+ String tableBasePath = basePath + "/asyncClusteringCompaction" +
RANDOM.nextInt(1000);
// Keep it higher than batch-size to test continuous mode
int totalRecords = 2000;
- // Initial bulk insert
- HoodieDeltaStreamer.Config cfg = TestHelpers.makeConfig(tableBasePath,
WriteOperationType.INSERT);
+ // user upsert as operation type.
+ HoodieDeltaStreamer.Config cfg = TestHelpers.makeConfig(tableBasePath,
WriteOperationType.UPSERT);
Review Comment:
Here we are testing that async clustering can run in concurrently for an MOR
table while async compaction is enabled. So, may be we can enable allow update
strategy. From my runs, as soon as replace commit succeeds, the test ends.
probably I did not hit it locally in few runs I had.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
