codope commented on code in PR #8837:
URL: https://github.com/apache/hudi/pull/8837#discussion_r1248137779
##########
hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/client/functional/TestHoodieBackedMetadata.java:
##########
@@ -1871,7 +1865,11 @@ private void
testTableOperationsImpl(HoodieSparkEngineContext engineContext, Hoo
validateMetadata(client);
// Restore
- client.restoreToInstant("20210101000600000",
writeConfig.isMetadataTableEnabled());
+ if (metaClient.getTableType() == COPY_ON_WRITE) {
+ assertThrows(HoodieRestoreException.class, () ->
client.restoreToInstant("20210101000600000",
writeConfig.isMetadataTableEnabled()));
+ } else {
+ client.restoreToInstant("20210101000600000",
writeConfig.isMetadataTableEnabled());
+ }
Review Comment:
There should not be a need to check this based on table type. Need to look
into why this fails for COW.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]