yihua commented on code in PR #9149:
URL: https://github.com/apache/hudi/pull/9149#discussion_r1258946099
##########
hudi-common/src/main/java/org/apache/hudi/common/config/HoodieMetadataConfig.java:
##########
@@ -251,50 +253,58 @@ public final class HoodieMetadataConfig extends
HoodieConfig {
.key(METADATA_PREFIX + ".record.index.enable")
.defaultValue(false)
.sinceVersion("0.14.0")
+ .markAdvanced()
.withDocumentation("Create the HUDI Record Index within the Metadata
Table");
public static final ConfigProperty<Integer>
RECORD_INDEX_MIN_FILE_GROUP_COUNT_PROP = ConfigProperty
.key(METADATA_PREFIX + ".record.index.min.filegroup.count")
.defaultValue(10)
.sinceVersion("0.14.0")
+ .markAdvanced()
.withDocumentation("Minimum number of file groups to use for Record
Index.");
public static final ConfigProperty<Integer>
RECORD_INDEX_MAX_FILE_GROUP_COUNT_PROP = ConfigProperty
.key(METADATA_PREFIX + ".record.index.max.filegroup.count")
.defaultValue(1000)
.sinceVersion("0.14.0")
+ .markAdvanced()
.withDocumentation("Maximum number of file groups to use for Record
Index.");
public static final ConfigProperty<Integer>
RECORD_INDEX_MAX_FILE_GROUP_SIZE_BYTES_PROP = ConfigProperty
.key(METADATA_PREFIX + ".record.index.max.filegroup.size")
.defaultValue(1024 * 1024 * 1024)
.sinceVersion("0.14.0")
+ .markAdvanced()
.withDocumentation("Maximum size in bytes of a single file group. Large
file group takes longer to compact.");
public static final ConfigProperty<Float> RECORD_INDEX_GROWTH_FACTOR_PROP =
ConfigProperty
.key(METADATA_PREFIX + ".record.index.growth.factor")
.defaultValue(2.0f)
.sinceVersion("0.14.0")
+ .markAdvanced()
.withDocumentation("The current number of records are multiplied by this
number when estimating the number of "
+ "file groups to create automatically. This helps account for
growth in the number of records in the dataset.");
public static final ConfigProperty<Long> MAX_READER_MEMORY_PROP =
ConfigProperty
.key(METADATA_PREFIX + ".max.reader.memory")
.defaultValue(1024 * 1024 * 1024L)
.sinceVersion("0.14.0")
+ .markAdvanced()
.withDocumentation("Max memory to use for the reader to read from
metadata");
public static final ConfigProperty<Integer> MAX_READER_BUFFER_SIZE_PROP =
ConfigProperty
.key(METADATA_PREFIX + ".max.reader.buffer.size")
.defaultValue(10 * 1024 * 1024)
.sinceVersion("0.14.0")
+ .markAdvanced()
Review Comment:
nit: let's put `.markAdvanced()` before `.sinceVersion()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
