yihua commented on code in PR #9149:
URL: https://github.com/apache/hudi/pull/9149#discussion_r1258950508
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/DataSourceOptions.scala:
##########
@@ -124,10 +124,12 @@ object DataSourceReadOptions {
val END_INSTANTTIME: ConfigProperty[String] = ConfigProperty
.key("hoodie.datasource.read.end.instanttime")
.noDefaultValue()
- .withDocumentation("Instant time to limit incrementally fetched data to. "
- + "New data written with an instant_time <= END_INSTANTTIME are fetched
out. Note that if `"
- + HoodieCommonConfig.INCREMENTAL_READ_HANDLE_HOLLOW_COMMIT.key() + "`
set to "
- + HollowCommitHandling.USE_STATE_TRANSITION_TIME + ", will use instant's
"
+ .withDocumentation("Used when `" + QUERY_TYPE.key() + "` is set to `" +
QUERY_TYPE_INCREMENTAL_OPT_VAL +
+ "`. Represents the instant time to limit incrementally fetched data to.
When not specified latest commit time from " +
+ "timeline is assumed by default. When specified, new data written with
an instant_time <= END_INSTANTTIME are fetched out. " +
+ "Point in time type queries makes more sense with begin and end instant
times specified. Note that if `"
Review Comment:
```suggestion
"Point in time type queries make more sense with begin and end instant
times specified. Note that if `"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
