danny0405 commented on code in PR #9007:
URL: https://github.com/apache/hudi/pull/9007#discussion_r1264602474
##########
hudi-common/src/main/java/org/apache/hudi/common/table/view/IncrementalTimelineSyncFileSystemView.java:
##########
@@ -448,14 +523,19 @@ protected void applyDeltaFileSlicesToPartitionView(String
partition, List<Hoodie
throw new IllegalStateException("Unknown diff apply mode=" + mode);
}
- HoodieTimeline timeline = deltaFileGroups.stream().map(df ->
df.getTimeline()).findAny().get();
+ // Here timeline is fetched from the existing file groups so it is
automatically completedWriteAndCompactionTimeline
+ HoodieTimeline completedWriteAndCompactionTimeline =
deltaFileGroups.stream().map(df -> df.getTimeline()).findAny().get();
List<HoodieFileGroup> fgs =
- buildFileGroups(viewDataFiles.values().stream(),
viewLogFiles.values().stream(), timeline, true);
+ buildFileGroups(viewDataFiles.values().stream(),
viewLogFiles.values().stream(), completedWriteAndCompactionTimeline, true);
storePartitionView(partition, fgs);
}
@Override
public HoodieTimeline getTimeline() {
return visibleActiveTimeline;
}
+
+ public boolean isLastIncrementalSyncSuccessful() {
Review Comment:
Marked as `@VisibleForTesting`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
