danny0405 commented on code in PR #9007:
URL: https://github.com/apache/hudi/pull/9007#discussion_r1264809549
##########
hudi-common/src/main/java/org/apache/hudi/common/table/timeline/HoodieTimeline.java:
##########
@@ -163,14 +163,19 @@ public interface HoodieTimeline extends Serializable {
*/
HoodieTimeline filterCompletedAndCompactionInstants();
- HoodieTimeline filterCompletedOrMajorOrMinorCompactionInstants();
+ /**
+ * File system view that is used for constructing file groups.
+ * This is the filtered timeline contains completed instants that are part
of either
+ * write timeline or savepoint timeline. Along with this it also includes
any pending compaction commits.
+ */
+ HoodieTimeline getFileSystemViewTimeline();
Review Comment:
I'm confused by the notion, what is even a file system view timeline? File
system view depends on the timeline for all kinds of file view APIs, that is a
clear concept to developers, but what is a file system view timeline, it seems
you are bringing in new notions?
Maybe you have good reason for these not including 'rollback and restore'
restrictions, but it is very subjective and also decided by specific use case
and it is hard to form a standard.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
