nsivabalan commented on code in PR #9203:
URL: https://github.com/apache/hudi/pull/9203#discussion_r1264768190
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieInternalConfig.java:
##########
@@ -46,6 +46,13 @@ public class HoodieInternalConfig extends HoodieConfig {
.withDocumentation("For SQL operations, if enables bulk_insert
operation, "
+ "this configure will take effect to decide overwrite whole table
or partitions specified");
+ public static final ConfigProperty<Boolean> ENABLE_PREPPED_MERGE_WRITES =
ConfigProperty
+ .key("hoodie.internal.sql.prepped.merge.enabled")
+ .defaultValue(true)
+ .markAdvanced()
+ .sinceVersion("0.14.0")
+ .withDocumentation("Controls whether spark sql optimized merge is
enabled.");
Review Comment:
lets name the the config
hoodie.spark.sql.optimized.merge.enable
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieInternalConfig.java:
##########
@@ -46,6 +46,13 @@ public class HoodieInternalConfig extends HoodieConfig {
.withDocumentation("For SQL operations, if enables bulk_insert
operation, "
+ "this configure will take effect to decide overwrite whole table
or partitions specified");
+ public static final ConfigProperty<Boolean> ENABLE_PREPPED_MERGE_WRITES =
ConfigProperty
+ .key("hoodie.internal.sql.prepped.merge.enabled")
+ .defaultValue(true)
+ .markAdvanced()
+ .sinceVersion("0.14.0")
+ .withDocumentation("Controls whether spark sql optimized merge is
enabled.");
Review Comment:
Lets move this to HoodieWriteConfig and ignore the one we are adding in
DataSourcEwriteOptions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
