nsivabalan commented on code in PR #9203:
URL: https://github.com/apache/hudi/pull/9203#discussion_r1267481558
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java:
##########
@@ -721,6 +721,8 @@ public class HoodieWriteConfig extends HoodieConfig {
+ "The class must be a subclass of
`org.apache.hudi.callback.HoodieClientInitCallback`."
+ "By default, no Hudi client init callback is executed.");
+ public static final String WRITE_PREPPED_MERGE_KEY =
"_hoodie.datasource.merge.prepped";
+
Review Comment:
I am also thinking, from a user standpoint we should have just 1 config to
enable or disable the optimized flow (irrespective of whether its mIT or
updates or deletes).
but internally we can use diff configs if we wish to differentiate MIT and
rest.
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/DataSourceOptions.scala:
##########
@@ -642,11 +642,18 @@ object DataSourceWriteOptions {
val DROP_PARTITION_COLUMNS: ConfigProperty[java.lang.Boolean] =
HoodieTableConfig.DROP_PARTITION_COLUMNS
val ENABLE_OPTIMIZED_SQL_WRITES: ConfigProperty[String] = ConfigProperty
- .key("hoodie.spark.sql.writes.optimized.enable")
+ .key("hoodie.spark.sql.optimized.writes.enable")
.defaultValue("true")
.markAdvanced()
.sinceVersion("0.14.0")
- .withDocumentation("Controls whether spark sql optimized update is
enabled.")
+ .withDocumentation("Controls whether spark sql prepped update and delete
is enabled.")
+
+ val ENABLE_OPTIMIZED_SQL_MERGE_WRITES: ConfigProperty[String] =
ConfigProperty
Review Comment:
I am also thinking, from a user standpoint we should have just 1 config to
enable or disable the optimized flow (irrespective of whether its mIT or
updates or deletes).
but internally we can use diff configs if we wish to differentiate MIT and
rest.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
