stream2000 commented on code in PR #9199:
URL: https://github.com/apache/hudi/pull/9199#discussion_r1277167344
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/cluster/util/ConsistentHashingUpdateStrategyUtils.java:
##########
@@ -83,7 +83,7 @@ private static void
extractHashingMetadataFromClusteringPlan(String instant, Hoo
ValidationUtils.checkState(p != null, "Clustering plan does not has
partition info, plan: " + plan);
// Skip unrelated clustering group
if (!recordPartitions.contains(p)) {
- return;
+ continue;
Review Comment:
It's a bug in the origin code. The set `recordPartitions` contains all
partitions that we care about, and we iterate over input groups in clustering
plan to construct hashing metadata. If current input group is not included in
`recordPartitions` we need to continue to check the next input group instead of
return directly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
