stream2000 commented on code in PR #9199:
URL: https://github.com/apache/hudi/pull/9199#discussion_r1277172498
##########
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/client/clustering/run/strategy/SparkConsistentBucketClusteringExecutionStrategy.java:
##########
@@ -79,15 +94,19 @@ public HoodieData<WriteStatus>
performClusteringWithRecordsRDD(HoodieData<Hoodie
HoodieWriteConfig newConfig =
HoodieWriteConfig.newBuilder().withProps(props).build();
RDDConsistentBucketBulkInsertPartitioner<T> partitioner = new
RDDConsistentBucketBulkInsertPartitioner<>(getHoodieTable(), strategyParams,
preserveHoodieMetadata);
+ addHashingChildNodes(partitioner, extraMetadata);
Review Comment:
Here I made a new interface call `ConsistentHashingBucketInsertPartitioner `
to share the common method `addHashingChildrenNodes ` between
`RDDConsistentBucketBulkInsertPartitioner ` and
`ConsistentBucketIndexBulkInsertPartitionerWithRows`. I didn't put the method
`addHashingChildrenNodes` in their closest parent class `BulkInsertPartitioner`
because It's all about consistent hashing bucket index and I don't want to
affect other partitioners. What do you think about this design here? Should I
keep the current design, move this to the parent class, or duplicate the code
for both partitioners?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
