KnightChess opened a new pull request, #9316:
URL: https://github.com/apache/hudi/pull/9316

   ### Change Logs
   
   will not update updateNumber metric when record not be update
   
   ### Impact
   low
   
   In the following method, updateNumber is determined by tagLocation, will not 
compare update or not. After this pr, it's may be different in these two. 
   In the following method, it will save to infight file, which I found is used 
to rollback failed commit, but not use the updateNumber metric, and 
insertNumber metric is not used too, so I think the two metric in infight file 
is not work, maybe I missed any key information, let me know
   
https://github.com/apache/hudi/blob/64310f57b06a40c8dbd1637989015e05f7039609/hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/commit/BaseCommitActionExecutor.java#L120
   
   ### Risk level (write none, low medium or high below)
   
   low
   
   ### Documentation Update
   
   None
   
   ### Contributor's checklist
   
   - [ ] Read through [contributor's 
guide](https://hudi.apache.org/contribute/how-to-contribute)
   - [ ] Change Logs and Impact were stated clearly
   - [ ] Adequate tests were added if applicable
   - [ ] CI passed
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to