danny0405 commented on code in PR #9316:
URL: https://github.com/apache/hudi/pull/9316#discussion_r1278973615
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieMergeHandle.java:
##########
@@ -268,14 +268,14 @@ protected void init(String fileId,
Iterator<HoodieRecord<T>> newRecordsItr) {
protected boolean writeUpdateRecord(HoodieRecord<T> newRecord,
HoodieRecord<T> oldRecord, Option<HoodieRecord> combineRecordOpt, Schema
writerSchema) throws IOException {
boolean isDelete = false;
if (combineRecordOpt.isPresent()) {
- updatedRecordsWritten++;
if (oldRecord.getData() != combineRecordOpt.get().getData()) {
// the incoming record is chosen
isDelete = HoodieOperation.isDelete(newRecord.getOperation());
} else {
// the incoming record is dropped
return false;
}
+ updatedRecordsWritten++;
}
Review Comment:
A valid fix, probably the code is copied from a legacy error logic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
