codope commented on code in PR #9165:
URL: https://github.com/apache/hudi/pull/9165#discussion_r1279053479
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/HoodieTable.java:
##########
@@ -688,7 +688,10 @@ private void
deleteInvalidFilesByPartitions(HoodieEngineContext context, Map<Str
LOG.info("Deleting invalid data file=" + partitionFilePair);
// Delete
try {
- fileSystem.delete(new Path(partitionFilePair.getValue()), false);
+ boolean result = fileSystem.delete(new
Path(partitionFilePair.getValue()), false);
+ if (!result) {
Review Comment:
Doing fs.exists check everytime may be ineffcient. Why not ignore i.e catch
and just log a warning? If the intention is to delete and file does not already
exist then what's point of retrying?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
