codope commented on code in PR #8718:
URL: https://github.com/apache/hudi/pull/8718#discussion_r1279097178
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/HoodieSparkSqlWriter.scala:
##########
@@ -1084,6 +1090,11 @@ object HoodieSparkSqlWriter {
if (mergedParams.contains(PRECOMBINE_FIELD.key())) {
mergedParams.put(HoodiePayloadProps.PAYLOAD_ORDERING_FIELD_PROP_KEY,
mergedParams(PRECOMBINE_FIELD.key()))
}
+ // enable inline compaction for batch writes if applicable
+ if (!isStreamingWrite &&
mergedParams.getOrElse(DataSourceWriteOptions.TABLE_TYPE.key(),
"COPY_ON_WRITE") == HoodieTableType.MERGE_ON_READ.name() &&
Review Comment:
can use HoodieTableType.COPY_ON_WRITE.name() instead of "COPY_ON_WRITE"
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/HoodieStreamingSink.scala:
##########
@@ -115,17 +116,24 @@ class HoodieStreamingSink(sqlContext: SQLContext,
updatedOptions =
updatedOptions.updated(HoodieWriteConfig.AUTO_ADJUST_LOCK_CONFIGS.key, "true")
updatedOptions =
updatedOptions.updated(HoodieSparkSqlWriter.SPARK_STREAMING_BATCH_ID,
batchId.toString)
+ // sqlContext: SQLContext,
+ // mode: SaveMode,
+ // optParams: Map[String, String],
+ // df: DataFrame,
+ // streamingWritesParamsOpt: Option[StreamingWriteParams],
+ // hoodieWriteClient: Option[SparkRDDWriteClient[_]] =
Option.empty
+
Review Comment:
let's remove this code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
