eric9204 commented on code in PR #9330:
URL: https://github.com/apache/hudi/pull/9330#discussion_r1280577727
##########
hudi-platform-service/hudi-metaserver/hudi-metaserver-client/src/main/java/org/apache/hudi/common/table/HoodieTableMetaserverClient.java:
##########
@@ -60,18 +60,17 @@ public class HoodieTableMetaserverClient extends
HoodieTableMetaClient {
public HoodieTableMetaserverClient(Configuration conf, String basePath,
ConsistencyGuardConfig consistencyGuardConfig,
String mergerStrategy,
FileSystemRetryConfig fileSystemRetryConfig,
- String databaseName, String tableName,
HoodieMetaserverConfig config) {
+ HoodieMetaserverConfig config) {
super(conf, basePath, false, consistencyGuardConfig,
Option.of(TimelineLayoutVersion.CURR_LAYOUT_VERSION),
config.getString(HoodieTableConfig.PAYLOAD_CLASS_NAME),
mergerStrategy, fileSystemRetryConfig);
- checkArgument(nonEmpty(databaseName), "database name is required.");
- checkArgument(nonEmpty(tableName), "table name is required.");
- this.databaseName = databaseName;
- this.tableName = tableName;
+ checkArgument(nonEmpty(tableConfig.getDatabaseName()), "database name is
required.");
+ checkArgument(nonEmpty(tableConfig.getTableName()), "table name is
required.");
+ this.databaseName = tableConfig.getDatabaseName();
Review Comment:
The table config belongs to `HoodieTableMetaClient`, will be initialized
first in the `HoodieTableMetaClient`'s constructor. it should not be
initialized again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
