danny0405 commented on code in PR #9330:
URL: https://github.com/apache/hudi/pull/9330#discussion_r1281395591
##########
hudi-platform-service/hudi-metaserver/hudi-metaserver-client/src/main/java/org/apache/hudi/common/table/HoodieTableMetaserverClient.java:
##########
@@ -63,15 +60,12 @@ public HoodieTableMetaserverClient(Configuration conf,
String basePath, Consiste
String databaseName, String tableName,
HoodieMetaserverConfig config) {
super(conf, basePath, false, consistencyGuardConfig,
Option.of(TimelineLayoutVersion.CURR_LAYOUT_VERSION),
config.getString(HoodieTableConfig.PAYLOAD_CLASS_NAME),
mergerStrategy, fileSystemRetryConfig);
- checkArgument(nonEmpty(databaseName), "database name is required.");
- checkArgument(nonEmpty(tableName), "table name is required.");
Review Comment:
Instead of null, can we change the param type as an Option ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
