jonvex commented on code in PR #9276:
URL: https://github.com/apache/hudi/pull/9276#discussion_r1280747849
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieBootstrapConfig.java:
##########
@@ -67,13 +67,6 @@ public class HoodieBootstrapConfig extends HoodieConfig {
.sinceVersion("0.6.0")
.withDocumentation("Selects the mode in which each file/partition in the
bootstrapped dataset gets bootstrapped");
- public static final ConfigProperty<String> DATA_QUERIES_ONLY = ConfigProperty
- .key("hoodie.bootstrap.data.queries.only")
- .defaultValue("false")
- .markAdvanced()
- .sinceVersion("0.14.0")
- .withDocumentation("Improves query performance, but queries cannot use
hudi metadata fields");
Review Comment:
I added this config when we were [trying to find ways to speed up bootstrap
reading](https://github.com/apache/hudi/pull/8303) . What it did was not do the
skeleton base file stitching and don't return the meta fields. With this pr, it
isn't necessary anymore, because now if you don't request any meta cols, that
will automatically happen inside the new reader so I think it is just confusing
to introduce this config and then have it not be necessary very soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
