jonvex commented on code in PR #9276:
URL: https://github.com/apache/hudi/pull/9276#discussion_r1281236300
##########
hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/spark/sql/hudi/command/MergeIntoHoodieTableCommand.scala:
##########
@@ -172,9 +172,9 @@ case class MergeIntoHoodieTableCommand(mergeInto:
MergeIntoTable) extends Hoodie
expressionSet.remove((attr, expr))
(attr, expr)
}
- if (resolving.isEmpty && rk._1.equals("primaryKey")) {
- throw new AnalysisException(s"Hudi tables with primary key are
required to match on all primary key colums. Column: '${rk._2}' not found")
- }
+ //if (resolving.isEmpty && rk._1.equals("primaryKey")) {
+ // throw new AnalysisException(s"Hudi tables with primary key are
required to match on all primary key colums. Column: '${rk._2}' not found")
+ //}
Review Comment:
need to uncomment before merging
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
