eric9204 commented on code in PR #9330:
URL: https://github.com/apache/hudi/pull/9330#discussion_r1282746143
##########
hudi-common/src/main/java/org/apache/hudi/common/table/HoodieTableMetaClient.java:
##########
@@ -690,7 +690,7 @@ private static HoodieTableMetaClient
newMetaClient(Configuration conf, String ba
? (HoodieTableMetaClient)
ReflectionUtils.loadClass("org.apache.hudi.common.table.HoodieTableMetaserverClient",
new Class<?>[]{Configuration.class, String.class,
ConsistencyGuardConfig.class, String.class, FileSystemRetryConfig.class,
String.class, String.class, HoodieMetaserverConfig.class},
conf, basePath, consistencyGuardConfig, recordMergerStrategy,
fileSystemRetryConfig,
- metaserverConfig.getDatabaseName(), metaserverConfig.getTableName(),
metaserverConfig)
+ Option.of(metaserverConfig.getDatabaseName()),
Option.of(metaserverConfig.getTableName()), metaserverConfig)
: new HoodieTableMetaClient(conf, basePath,
Review Comment:
The table name can never be empty, but the database name may be empty.
is it necessary to change them all to `Option.ofNullable`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
